Message10603

Author zyasoft
Recipients flegall, zyasoft
Date 2016-01-07.05:58:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1452146324.37.0.917604939368.issue2154@psf.upfronthosting.co.za>
In-reply-to
Content
Florent, I finally had a chance to go through JSR 223 support today. The change is trivial:

    [junit] Running org.python.indexer.TestBase
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.376 sec
    [junit] Running org.python.jsr223.ScriptEngineIOTest
diff -r e1ae43e28fbf src/org/python/util/PythonInterpreter.java
--- a/src/org/python/util/PythonInterpreter.java        Wed Jan 06 22:36:07 2016 -0700
+++ b/src/org/python/util/PythonInterpreter.java        Wed Jan 06 22:55:58 2016 -0700
@@ -78,7 +78,7 @@
      * @param dict a Python mapping object (e.g., a dictionary) for use as the default namespace
      */
     public static PythonInterpreter threadLocalStateInterpreter(PyObject dict) {
-        return new PythonInterpreter(dict, null, true);
+        return new PythonInterpreter(dict, new PySystemState(), true);
     }

     /**

So I'm going to apply it now because the change makes sense: we should isolate each engine with its own PySystemState. Beta 3 should be a good chance to prove  whether this is truly the case or not.

I would like to add your test to our test suite, so if you could submit a contributor agreement (https://www.python.org/psf/contrib/contrib-form/), I will do add accordingly.

Sorry this has taken so long!
History
Date User Action Args
2016-01-07 05:58:44zyasoftsetmessageid: <1452146324.37.0.917604939368.issue2154@psf.upfronthosting.co.za>
2016-01-07 05:58:44zyasoftsetrecipients: + zyasoft, flegall
2016-01-07 05:58:44zyasoftlinkissue2154 messages
2016-01-07 05:58:43zyasoftcreate