Author stefan.richthofer
Recipients nickmbailey, stefan.richthofer, zyasoft
Date 2016-02-03.22:24:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Looking at issue 2280 in detail again I agree that our switch to a non-blocking lock in should solve 2280 too, given that it also involved Closer.dismiss and
So in principle I'd be willing to accept your (@Nick) patch. I'm a bit concerned though that we don't have handy unittests for this stuff.

So before accepting it I'd like to

- have Jim review it since he applied the original fix of issue 2280
- assess whether there's a difference to "just" reverting the patch for 2280 (which now appears to be obsolete) and - if yes - what, why etc
- understand/solve why the pullrequest triggers this error message "Your tests failed on CircleCI"

Nick, I suppose you're the best person to help answer these quickly, then we're ready to go.
Date User Action Args
2016-02-03 22:24:58stefan.richthofersetmessageid: <>
2016-02-03 22:24:58stefan.richthofersetrecipients: + stefan.richthofer, zyasoft, nickmbailey
2016-02-03 22:24:58stefan.richthoferlinkissue2457 messages
2016-02-03 22:24:58stefan.richthofercreate