Message10714

Author	nickmbailey
Recipients	nickmbailey, stefan.richthofer, zyasoft
Date	2016-02-03.22:36:08
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1454538968.89.0.171435501961.issue2457@psf.upfronthosting.co.za>
In-reply-to

Content
There are 2 differences between this and reverting 2280. 1. I use a synchronized collection for the set of things that need to be closed and therefore don't synchronize on registerCloser/unregisterCloser. 2. I pass in the PySystemStateCloser instance to the shutdown thread and let the shutdown thread synchronize on that. Previously it was just synchronizing on it's own instance which isn't what we wanted. I'll look into the circle ci failure.

There are 2 differences between this and reverting 2280.

1. I use a synchronized collection for the set of things that need to be closed and therefore don't synchronize on registerCloser/unregisterCloser.

2. I pass in the PySystemStateCloser instance to the shutdown thread and let the shutdown thread synchronize on that. Previously it was  just synchronizing on it's own instance which isn't what we wanted.

I'll look into the circle ci failure.

History
Date	User	Action	Args
2016-02-03 22:36:08	nickmbailey	set	messageid: <1454538968.89.0.171435501961.issue2457@psf.upfronthosting.co.za>
2016-02-03 22:36:08	nickmbailey	set	recipients: + nickmbailey, zyasoft, stefan.richthofer
2016-02-03 22:36:08	nickmbailey	link	issue2457 messages
2016-02-03 22:36:08	nickmbailey	create