Message11575

Author stefan.richthofer
Recipients birkoff, stefan.richthofer, zyasoft
Date 2017-09-07.08:12:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1504771970.36.0.468890725247.issue2622@psf.upfronthosting.co.za>
In-reply-to
Content
Jim, I'd like to veto this fix. While it might work well, remember we unified PyDictionary and PyStringMap under AbstractDict.
So I'd suggest to modify Encoder.java to accept any AbstractDict in
https://github.com/jythontools/jython/blob/master/src/org/python/modules/_json/Encoder.java#L141

and also switch to AbstractDict in

https://github.com/jythontools/jython/blob/master/src/org/python/modules/_json/Encoder.java#L119

With that no further modification should be required (and it avoids to copy a dict).
AbstractDict was intended to be the migration path from PyDictionary/PyStringmap to a proper solution. I'd suggest we move to AbstractDict wherever issues regarding this pop up.
History
Date User Action Args
2017-09-07 08:12:50stefan.richthofersetmessageid: <1504771970.36.0.468890725247.issue2622@psf.upfronthosting.co.za>
2017-09-07 08:12:50stefan.richthofersetrecipients: + stefan.richthofer, zyasoft, birkoff
2017-09-07 08:12:50stefan.richthoferlinkissue2622 messages
2017-09-07 08:12:49stefan.richthofercreate