Message11886

Author jeff.allen
Recipients jeff.allen, zyasoft
Date 2018-04-08.08:31:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1523176284.42.0.682650639539.issue2662@psf.upfronthosting.co.za>
In-reply-to
Content
In fact we do something similar when we encounter a non-public class here:
https://hg.python.org/jython/file/d74f8c2cd56f/src/org/python/core/PyJavaType.java#l383

However, the role that "public" plays here needs to be replaced by "accessible", in the sense of modular accessibility from the unnamed module. I wonder if that can be done without invoking Java 9 specifics?

There's a bug in that if-statement too. The name field for core classes, has already been changed from the Java class name at:
https://hg.python.org/jython/file/d74f8c2cd56f/src/org/python/core/PyJavaType.java#l324
and so the prefix tested is no longer there, which means we perfrom this unnecessarily for core classes. That should be fixed, but for now it gives me lots of opportunity to see it in action :/

Also, the logic of this seems odd:
https://hg.python.org/jython/file/d74f8c2cd56f/src/org/python/core/PyJavaType.java#l957
We check to see if the class is non-public, after the merge?
History
Date User Action Args
2018-04-08 08:31:24jeff.allensetmessageid: <1523176284.42.0.682650639539.issue2662@psf.upfronthosting.co.za>
2018-04-08 08:31:24jeff.allensetrecipients: + jeff.allen, zyasoft
2018-04-08 08:31:24jeff.allenlinkissue2662 messages
2018-04-08 08:31:23jeff.allencreate