Message11994

Author	jamesmudd
Recipients	jamesmudd, jeff.allen, stefan.richthofer
Date	2018-05-17.21:26:34
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1526592394.7.0.682650639539.issue2672@psf.upfronthosting.co.za>
In-reply-to

Content
I have updated the pull request https://github.com/jythontools/jython/pull/102 I have added more tests covering the other cases where this could fail. The fix I have implemented is to delegate all the int methods to the BigInteger version counterparts. This makes for quite a simplification as well as fixing this bug. It is debatable if this will reduce performance, I haven't benchmarked it. I suspect it will be very close, the new way can make use of BigInteger optimisations.

I have updated the pull request https://github.com/jythontools/jython/pull/102

I have added more tests covering the other cases where this could fail. The fix I have implemented is to delegate all the int methods to the BigInteger version counterparts. This makes for quite a simplification as well as fixing this bug.

It is debatable if this will reduce performance, I haven't benchmarked it. I suspect it will be very close, the new way can make use of BigInteger optimisations.

History
Date	User	Action	Args
2018-05-17 21:26:34	jamesmudd	set	messageid: <1526592394.7.0.682650639539.issue2672@psf.upfronthosting.co.za>
2018-05-17 21:26:34	jamesmudd	set	recipients: + jamesmudd, jeff.allen, stefan.richthofer
2018-05-17 21:26:34	jamesmudd	link	issue2672 messages
2018-05-17 21:26:34	jamesmudd	create