Message12042

Author	jamesmudd
Recipients	jamesmudd, jeff.allen, stefan.richthofer
Date	2018-07-05.20:29:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1530822577.51.0.56676864532.issue2672@psf.upfronthosting.co.za>
In-reply-to

Content
I have updated the pull request to use the string constant. Also I investigated the other cases further and they actually worked ok. The reason is Integer.{toHexString, toOctalString, toBinaryString} work in unsigned. From the Javadoc: Returns a string representation of the integer argument as an unsigned integer in base 8. The unsigned integer value is the argument plus 232 if the argument is negative; otherwise, it is equal to the argument. So those don't require special casing and there are now tests covering those as well.

I have updated the pull request to use the string constant.

Also I investigated the other cases further and they actually worked ok. The reason is Integer.{toHexString, toOctalString, toBinaryString} work in unsigned. From the Javadoc:
	Returns a string representation of the integer argument as an unsigned integer in base 8.
	The unsigned integer value is the argument plus 232 if the argument is negative; otherwise, it is equal to the argument.

So those don't require special casing and there are now tests covering those as well.

History
Date	User	Action	Args
2018-07-05 20:29:37	jamesmudd	set	messageid: <1530822577.51.0.56676864532.issue2672@psf.upfronthosting.co.za>
2018-07-05 20:29:37	jamesmudd	set	recipients: + jamesmudd, jeff.allen, stefan.richthofer
2018-07-05 20:29:37	jamesmudd	link	issue2672 messages
2018-07-05 20:29:36	jamesmudd	create