Message12136

Author	jeff.allen
Recipients	darjus, jamesmudd, jeff.allen, stefan.richthofer
Date	2018-10-13.16:43:33
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1539449014.28.0.788709270274.issue2708@psf.upfronthosting.co.za>
In-reply-to

Content
It is a fairly big refactor ... and it does not quite live up to the description. But the thing I know I broke here (sorry): https://hg.python.org/jython/rev/623eaa3d7834 I fixed here: https://hg.python.org/jython/rev/2adcf0e29407 test_urllib2net passes for me at both these revisions on Java 7 & 8. Also at the tip on 11. All on Windows. I'd been attributing those failures to the network environbment in which the CI is run. I agree it is useless if it just shows red all the time for reasons we think are spurious, but there is a bit to do to fix it. I can't say I really follow the scripts. Our CI needs revisiting on quite a few points.

It is a fairly big refactor ... and it does not quite live up to the description. But the thing I know I broke here (sorry):
https://hg.python.org/jython/rev/623eaa3d7834
I fixed here:
https://hg.python.org/jython/rev/2adcf0e29407

test_urllib2net passes for me at both these revisions on Java 7 & 8. Also at the tip on 11. All on Windows.

I'd been attributing those failures to the network environbment in which the CI is run. I agree it is useless if it just shows red all the time for reasons we think are spurious, but there is a bit to do to fix it. I can't say I really follow the scripts. Our CI needs revisiting on quite a few points.

History
Date	User	Action	Args
2018-10-13 16:43:34	jeff.allen	set	messageid: <1539449014.28.0.788709270274.issue2708@psf.upfronthosting.co.za>
2018-10-13 16:43:34	jeff.allen	set	recipients: + jeff.allen, darjus, stefan.richthofer, jamesmudd
2018-10-13 16:43:34	jeff.allen	link	issue2708 messages
2018-10-13 16:43:33	jeff.allen	create