Message12264

Author	stefan.richthofer
Recipients	jeff.allen, stefan.richthofer
Date	2019-01-04.23:23:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1546644184.6.0.919972254434.issue2663@roundup.psfhosted.org>
In-reply-to

Content
I took a short look at the binascii.b2a_base64 implementation https://github.com/jythontools/jython/blob/2dd11357668506cafd71697a7632ad4527c76b8a/src/org/python/modules/binascii.java#L433 It looks dubious to me that it attempts to store the binary data in a string. Does Java accept this? I'd suspect that Java might attempt to decode it via the platform default coding. However, it's certainly tested and as long as it retrieves what it encodes it should work fine. The binary data is finally retrieved using String.getBytes...?

I took a short look at the binascii.b2a_base64 implementation
https://github.com/jythontools/jython/blob/2dd11357668506cafd71697a7632ad4527c76b8a/src/org/python/modules/binascii.java#L433

It looks dubious to me that it attempts to store the binary data in a string. Does Java accept this? I'd suspect that Java might attempt to decode it via the platform default coding. However, it's certainly tested and as long as it retrieves what it encodes it should work fine.
The binary data is finally retrieved using String.getBytes...?

History
Date	User	Action	Args
2019-01-04 23:23:04	stefan.richthofer	set	messageid: <1546644184.6.0.919972254434.issue2663@roundup.psfhosted.org>
2019-01-04 23:23:04	stefan.richthofer	set	recipients: + stefan.richthofer, jeff.allen
2019-01-04 23:23:04	stefan.richthofer	link	issue2663 messages
2019-01-04 23:23:04	stefan.richthofer	create