Author jeff.allen
Recipients jeff.allen
Date 2019-04-01.21:51:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
The more I try to increase test coverage, the more dubious I get about the way we have added the Python mapping API to Java Map objects.

I've noticed that our modified version of test_dict, while it uses an instance of the type under test some of the time, obtained from self._make_dict(), where it refers to the type itself, still refers to dict. This happens particularly where it needs to define a sub-class of the type under test. Or rather used to. But correcting this leads to many more test failures.

Sub-classing works really badly: test_fromkeys uses subclassing extensively, but the overrides of __new__ and __setitem__ do not get called. This should probably not be a surprise, as there is no *Derived class to hook the special methods. At least, I don't think there is.
Date User Action Args
2019-04-01 21:51:47jeff.allensetmessageid: <>
2019-04-01 21:51:47jeff.allensetrecipients: + jeff.allen
2019-04-01 21:51:47jeff.allenlinkissue2746 messages
2019-04-01 21:51:47jeff.allencreate