Message13096

Author jeff.allen
Recipients darjus, jeff.allen, zyasoft
Date 2020-06-03.09:55:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1591178105.88.0.0999883303023.issue2892@roundup.psfhosted.org>
In-reply-to
Content
The discrepancies in what the sign-on banner and sys._git produce has been bugging me. I fell foul of it too in the tripwires in the build that detect whether we're at the tag matching the release, by checking build.git.tag against jython.release.

The sign-on includes sys._git[1]. Here are some examples of sys._git from CPython:
('CPython', 'v2.7.16', '413a49145e')
('CPython', 'v3.7.3', 'ef4ec6ed12')
('CPython', 'tags/v3.8.0', 'fa919fd')
and from my dry-run
('Jython', 'tags/v2.7.3a1', '625fdf3b1')

Why the slightly ugly "tags/" prefix in some cases and not others? The code in configure.ac has not changed between these version. In all cases, we are seeing the output of 'git describe --all --always --dirty'.

It turns out that the culprit is actually git, which differs by version due to a regression fixed here:
https://github.com/git/git/commit/1bba00130a1a0332ec0ad2f878a09ca9b2b18ee2
History
Date User Action Args
2020-06-03 09:55:05jeff.allensetmessageid: <1591178105.88.0.0999883303023.issue2892@roundup.psfhosted.org>
2020-06-03 09:55:05jeff.allensetrecipients: + jeff.allen, zyasoft, darjus
2020-06-03 09:55:05jeff.allenlinkissue2892 messages
2020-06-03 09:55:05jeff.allencreate