Message2558

Author h_eriksson
Recipients
Date 2007-02-12.07:39:37
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
This is exactly the kind of feedback I was looking for. Thanks!

Hmmm... it's been a while so I'm not 100% sure, but I think I wanted to wrap it to be able to use PyIterator's next() method logic for throwing the stored exception... might be overkill, I'll have a look at it.

You're right about toInt vs Py.py2int. I stared myself blind at getting the tests to pass :-) 

I also agree about the PyList in cycle. It was quite handy to be able to get a PyIterator from it that easily. But as you say, it has some unnecessary overhead to it in this case. I'll make sure to fix that.

I'll get on it as soon as I get my new laptop (I recently switched employer and haven't recieved one yet). Might take a week or two though :-( 
I don't remember seeing any doctest failures but now I'm not sure... I'll get back to you on that one.
History
Date User Action Args
2008-02-20 17:18:36adminlinkissue1608656 messages
2008-02-20 17:18:36admincreate