Message2659
>It's easier to apply and test these things if you attach your patch as a
>file instead of putting it in your message
Ah. So sorry. First time I submitted a patch this way. I'll attach them from now on.
I don't know why this appears twice. The contents appear identical, just created @ 09:37 and 18:36. I created the earlier one - while having my morning cup of coffee. I don't know how the other one got created. I've closed the other one as a Dupe.
1665260 just fixes types.UnicodeType == <type 'str'> instead of <type 'unicode'>
This patch contains that _AND_ optimizations for the initialization.
If you're happy with the optimization, you can ignore 166260 and just apply this one.
Q: I submitted these as 2 separate patches they're separate issues (fix vs. optimization) that, unfortunately, overlap the same code. I didn't see any comments specifically about this in the patch submission guidelines so I assumed 1-patch-per-issue is preferred, as many projects follow that policy e.g. the Linux kernel. What's preferred for Jython? |
|
Date |
User |
Action |
Args |
2008-02-20 17:18:40 | admin | link | issue1665693 messages |
2008-02-20 17:18:40 | admin | create | |
|