Message2684

Thanks for the patch, and for taking care to include updated test cases. The __doc__ problem may be the one reported in bug 1605006, so i think you're correct not to worry about it here.

Minor thing: i have the vague notion that the null __dict__ behavior may be cpython implementation specific. Eg pypy seems to produce an empty __dict__ after __new__ instead of None, and modifies test_module for this. So we might do well enough without the extra compatibility work, though i don't feel that strongly about it.

The test suite seemed to run without any new regressions when trying the patch on trunk. Absent further better informed feedback i'd favour committing to 2.3 at least.

- kz