Message2734

Author pekka.klarck
Recipients
Date 2007-07-27.00:04:41
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
I looked at the patch briefly and in general docstrings look good to me especially compared to current ones. Some things that could still be fixed are listed below.

- Added docstrings aren't always following PEP 257 Docstring Conventions available at http://www.python.org/dev/peps/pep-0257/

- Docstrings on Python 2.5 os.py have more content than these so perhaps they could be used as a base (keeping in mind that there can be differences between versions).

- Mentioning java2 is not really needed in utime since, AFAIK, it means Java 1.2 and Java 1.4 is the minimum for Jython 2.2. The check 'hasattr(File, "setLastModified")' should probably also be removed from the code.

- The doc for utime could be slightly more clear since now it first says that atime and mtime are changed and then that only mtime is. Mentioning that the latter is due to Java limitations might be good.

- It would be helpful to tell what information is actually returned by stat.

History
Date User Action Args
2008-02-20 17:18:43adminlinkissue1758904 messages
2008-02-20 17:18:43admincreate