Message2755
There were still a couple problems in the latest patch, but they were small enough that I went ahead and fixed them and committed this in r3365 on the 2.3 branch.
First, don't include commented out printouts or any stuff like that that shouldn't be in the final committed code in the patch. It should be in a state where I can apply the patch and commit it without modification.
An object being an instance of PyDictionary doesn't make it a dict in the same way that an object being a PySequence doesn't make it a sequence. Instead of checking instanceof, I changed it to look for the keys attr like the code does in CPython.
We're trying to increase the javadoc coverage on publicly exposed methdods and classes in Jython, so anything that's at that level should have some javadocs.
I deleted the completely commented out test from test_enumerate. Is adding a __reversed__ method to classes something from 2.6? I didn't see anything about it in the 2.5 source I looked at. In any case, if something is going to need additional features later, I'd recommend filing a bug for it rather than burying it in commented out source code. No one is going to go through the source looking for things that are missing, but a bug won't get lost like that. |
|
Date |
User |
Action |
Args |
2008-02-20 17:18:44 | admin | link | issue1761139 messages |
2008-02-20 17:18:44 | admin | create | |
|