Message2784

Author cgroves
Recipients
Date 2007-08-12.06:33:22
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
My understanding is that decode should return unicode objects since it's turning an encoded sequence of bytes into unicode characters.  However, I don't see why datetime should care if it gets a str or a unicode object for unpickling.  So I'd prefer to fix this with the patch I'm attaching.  

Instead of changing all of the decode methods to return a PyObject, I just changed all of the isinstance checks for str to use basestring instead.  str and unicode both descend from it.  Sound good?
File Added: datetime_unpickle_basestring.patch
History
Date User Action Args
2008-02-20 17:18:45adminlinkissue1772134 messages
2008-02-20 17:18:45admincreate