Message2912
__copy__ is still on PyDefaultDict and PyException is
still modified.
In PyDeque, curly braces on all blocks.
Instead of iterating over a sequence with explicit calls
to data.__getitem__ in deque_init, you could just call
deque_extend with a PySequenceIter wrapping data.
You shouldn't need to check for __iter__ returning null in
deque_extend. Was it returning null somewhere?
Use Py.One instead of new PyInteger(1)
Rather than rightlink and leftlink, I'd just call the
fields on Node left and right.
Those are some pretty small complaints though. It looks like this is just about ready to go. |
|
Date |
User |
Action |
Args |
2008-02-20 17:18:51 | admin | link | issue1804242 messages |
2008-02-20 17:18:51 | admin | create | |
|