Message2913

My doubts and Charlie's answers:
================================
> PyDefaultDict :
> -----------
> CPython has two functions for doing shallow copy.
> 1) copy  2) __copy__
> That's why I too have added two functions. But I removed
>  the class specific __copy__ function because that is not in
> PyObject and we don't need to override.  Do you want me to
> remove copy function?

As far as I can tell, we don't have __copy__ anywhere else in Jython.
Why does PyDefaultdictionary need it?
>
> I didn't change in PyException.java file. But I have added one
> more KeyError function with parameter type PyObject. It is
> needed to throw from __missing__ function of PyDefaultDict.
> In CPython, the key itself is printed as error message. So I
> followed the same. If I didn't add this, I would get errors
> while running test cases.

Is the string value of the key error used, or the key itself?  If it's
the former, just toString the key and pass it through.  No need to
modify PyException.

> PyDeque:
> -------
> I have got confused from the comment
> "In PyDeque, curly braces on all blocks" because you asked me
> to add braces for all blocks when you reviewed defaultdict.
> Here, I interpreted like you want me to remove unnecessary
> curly braces. Please clarify me.

I'm asking for you to finish fixing all of the places without curly
braces on blocks.  I found at least one place(in PyDeque's init I
think) where there were blocks without curly braces.