Message2942

Author byronf
Recipients
Date 2007-12-12.01:31:36
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
> Since most of AbstractSet operates on the Iterator returned by its
> concrete implementation, and PyMapSet has to implement iterator, the
> methods on AbstractSet will go through that iterator.  I've attached
> a new version of your patch that uses AbstractSet and passes your
> tests.  It eliminates 9 methods: hashCode, equals, retainAll,
> removeAll, containsAll, add, addAll, toArray and isEmpty.  Am I
> missing something?

Yea, that looks good, I didn't realize that the AbstractSet explicitly
used the Iterator for the interface, as opposed to an implementation
detail subject to possible change.  Could probably remove size() and
clear() also.
History
Date User Action Args
2008-02-20 17:18:52adminlinkissue1817565 messages
2008-02-20 17:18:52admincreate