Message2955
You can't just say sys.platform is the underlying os. Jython runs on a separate platform, java, that has different assumptions and qualities than any other base platform. Changing platform.py is fine, you'll notice that I said you were heading in the right direction in my comments, it's just that those modifications should be such that CPython and Jython can use the same module. If that isn't possible, explain why and we can start to use a forked version.
With this patch in place, regrtest fails internally before it even runs a single test. The first thing I do when evaluating a patch, before even looking at the code, is to run regrtest with it. If it causes unexplained test failures, I'm not going to apply it. |
|
Date |
User |
Action |
Args |
2008-02-20 17:18:53 | admin | link | issue1838658 messages |
2008-02-20 17:18:53 | admin | create | |
|