Message5452

Author	nriley
Recipients	fwierzbicki, nriley, tiago182
Date	2010-01-24.01:33:13
SpamBayes Score	0.0005948934
Marked as misclassified	No
Message-id	<1264296794.84.0.35695666042.issue1536@psf.upfronthosting.co.za>
In-reply-to

Content
So there are two problems here: first, we're not dealing with an exception that occurs during parsing correctly; and second, we're closing the Reader after we finish compiling. The first problem is trivially fixable, and I have done so (r6963). I don't see anything in JSR 223 that mandates the Reader not be closed, but then again, I'm not sure why we're closing it. The original code came from Frank's parser work in r5005 (http://fisheye3.atlassian.com/changelog/jython/?cs=5005). Frank - do you remember why you did this?

So there are two problems here: first, we're not dealing with an exception that occurs during parsing correctly; and second, we're closing the Reader after we finish compiling.

The first problem is trivially fixable, and I have done so (r6963).

I don't see anything in JSR 223 that mandates the Reader not be closed, but then again, I'm not sure why we're closing it.  The original code came from Frank's parser work in r5005 (http://fisheye3.atlassian.com/changelog/jython/?cs=5005).  Frank - do you remember why you did this?

History
Date	User	Action	Args
2010-01-24 01:33:14	nriley	set	messageid: <1264296794.84.0.35695666042.issue1536@psf.upfronthosting.co.za>
2010-01-24 01:33:14	nriley	set	recipients: + nriley, fwierzbicki, tiago182
2010-01-24 01:33:14	nriley	link	issue1536 messages
2010-01-24 01:33:14	nriley	create