Message5877

Author zyasoft
Recipients adam.spiers, amak, colinhevans, fwierzbicki, matt_brinkley, pjenvey, zyasoft
Date 2010-07-07.14:35:47
SpamBayes Score 0.002653644
Marked as misclassified No
Message-id <1278513350.32.0.633932019393.issue1327@psf.upfronthosting.co.za>
In-reply-to
Content
Matt,

Two things:

1. Can you provide a patch file of your changes and attach? It's much easier to evaluate and apply without inadvertent bugs being introduced. It's also trivial:

svn diff > issue1327.patch

(You can also control which files are diffed if you have other stuff changed.)

2. For Closers, I think we should register them with the PySystemState; this represents the overall global state and it's CPython's execution model too. We should do the same with the ThreadStateMapping so the shutdown is done with respect to PySystemState. (Such states can be shared by interpreters, but as clear in the use of PythonInterpreter#cleanup, only with care!) One of the biggest issues with Jython internals now is too much unnecessary globality, perhaps because it was more efficient on earlier JVMs. Regardless we don't want to introduce more now.

However, we may want some convenience methods to get at all of these states/interpreters and do things like shut them all down (but only maintain weakrefs! we don't want to move the problem). 

[This week I'm camping in Lake Dillon, which means far better connectivity than last week in Aspen/Crested Butte!]
History
Date User Action Args
2010-07-07 14:35:50zyasoftsetmessageid: <1278513350.32.0.633932019393.issue1327@psf.upfronthosting.co.za>
2010-07-07 14:35:50zyasoftsetrecipients: + zyasoft, fwierzbicki, amak, pjenvey, colinhevans, matt_brinkley, adam.spiers
2010-07-07 14:35:49zyasoftlinkissue1327 messages
2010-07-07 14:35:48zyasoftcreate