Message7338

Author jeff250
Recipients amak, bzimmer, jeff250, kzuberi, leouserz
Date 2012-07-27.19:13:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1343416418.05.0.496301983952.issue590519@psf.upfronthosting.co.za>
In-reply-to
Content
I'm interested in seeing this bug resolved.  I'm attaching a proposed patch.

My reasoning behind the patch is that if the last statement executed did *not* return a result set, then we want the rowcount to return the value of updatecount.  But if it didn't return a result set, then updatecount will be an integer >= 0, so we check for that and just return the updatecount.

Otherwise, if the last statement executed *did* return a result set, then we want to just return the rowcount value as before.  But if it did return a result set, then updatecount will be None, so in that case we return the rowcount value as before.

This patch preserves the old updatecount field behavior for now to give people relying on it time to transition.

Feedback welcome. :)
History
Date User Action Args
2012-07-27 19:13:38jeff250setmessageid: <1343416418.05.0.496301983952.issue590519@psf.upfronthosting.co.za>
2012-07-27 19:13:38jeff250setrecipients: + jeff250, bzimmer, leouserz, kzuberi, amak
2012-07-27 19:13:37jeff250linkissue590519 messages
2012-07-27 19:13:37jeff250create