Issue1226

classification
Title: asyncore.dispatcher._map is deleted for no reason
Type: Severity: normal
Components: Library Versions: 2.5.1, 2.5b0
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: amak Nosy List: amak, billiejoex
Priority: Keywords:

Created on 2009-01-10.15:43:16 by billiejoex, last changed 2009-02-04.15:34:15 by amak.

Messages
msg4021 (view) Author: Giampaolo Rodola' (billiejoex) Date: 2009-01-10.15:43:16
def add_channel(self, map=None):
        #self.log_info('adding channel %s' % self)
        if map is None:
            if hasattr(self, '_map'):
                map = self._map
                del self._map
            else:
                map = socket_map
        if not hasattr(self, '_fileno'):
            self._fileno = self.socket.fileno()
        map[self._fileno] = self


The line "del self._map" breaks pyftpdlib [1] and, I presume, all other
other applications built on top of asyncore not using a custom socket_map.
There's really no reason to delete that attribute.

[1] http://code.google.com/p/pyftpdlib/
msg4129 (view) Author: Alan Kennedy (amak) Date: 2009-02-04.15:34:14
This bug refers solely to the previous version of asyncore.
I have just checked in a new version, which is the cpython 2.5 asyncore
ported to jython 2.5.
Therefore this bug is no longer relevant; closing as "out of date".
History
Date User Action Args
2009-02-04 15:34:15amaksetstatus: open -> closed
resolution: out of date
messages: + msg4129
2009-01-29 21:07:56amaksetassignee: amak
nosy: + amak
2009-01-10 15:43:16billiejoexcreate