Message4021

Author billiejoex
Recipients billiejoex
Date 2009-01-10.15:43:16
SpamBayes Score 0.048789237
Marked as misclassified No
Message-id <1231602196.33.0.946538951459.issue1226@psf.upfronthosting.co.za>
In-reply-to
Content
def add_channel(self, map=None):
        #self.log_info('adding channel %s' % self)
        if map is None:
            if hasattr(self, '_map'):
                map = self._map
                del self._map
            else:
                map = socket_map
        if not hasattr(self, '_fileno'):
            self._fileno = self.socket.fileno()
        map[self._fileno] = self


The line "del self._map" breaks pyftpdlib [1] and, I presume, all other
other applications built on top of asyncore not using a custom socket_map.
There's really no reason to delete that attribute.

[1] http://code.google.com/p/pyftpdlib/
History
Date User Action Args
2009-01-10 15:43:16billiejoexsetrecipients: + billiejoex
2009-01-10 15:43:16billiejoexsetmessageid: <1231602196.33.0.946538951459.issue1226@psf.upfronthosting.co.za>
2009-01-10 15:43:16billiejoexlinkissue1226 messages
2009-01-10 15:43:16billiejoexcreate