Issue876840

classification
Title: jythonc --skip option doesn\\\'t skip
Type: Severity: normal
Components: Jythonc compiler Versions:
Milestone:
process
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: fwierzbicki, psurry
Priority: low Keywords:

Created on 2004-01-14.14:08:52 by psurry, last changed 2009-03-13.23:35:53 by fwierzbicki.

Messages
msg886 (view) Author: Patrick Surry (psurry) Date: 2004-01-14.14:08:52
In tools/jythonc/compiler.py::Compiler.addDependencies() 
you have this:

        ...
        if self.deep:
            for filename, name in self.depends.items():
                #self.write('%s requires %s' % (mod.name, 
name))
                if name in self.skip:
                    self.write('  %s skipping %s' % (mod.name, 
name))
                self.compilefile(filename, name)

So it's happily saying it's skipping things, but then going 
ahead and still compilefile()'ng them.

Changing it to below (the double loop because this 
function gets called recursively within the second loop):

    ...
        if self.deep:
            for filename, name in self.depends.items():
                if name in self.skip:
                    del self.depends[filename]
                    self.write('  %s skipping %s' % (mod.name, 
name))

            for filename, name in self.depends.items():
                # self.write('%s requires %s' % (mod.name, 
name))
                self.compilefile(filename, name)

seems to work, but I don't really understand the code 
base well enough to know if this is the 'right' fix.
msg4267 (view) Author: Frank Wierzbicki (fwierzbicki) Date: 2009-03-13.23:35:53
jythonc is unmaintained
History
Date User Action Args
2009-03-13 23:35:53fwierzbickisetstatus: open -> closed
resolution: wont fix
messages: + msg4267
nosy: + fwierzbicki
2004-01-14 14:08:52psurrycreate