Message886

Author psurry
Recipients
Date 2004-01-14.14:08:52
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
In tools/jythonc/compiler.py::Compiler.addDependencies() 
you have this:

        ...
        if self.deep:
            for filename, name in self.depends.items():
                #self.write('%s requires %s' % (mod.name, 
name))
                if name in self.skip:
                    self.write('  %s skipping %s' % (mod.name, 
name))
                self.compilefile(filename, name)

So it's happily saying it's skipping things, but then going 
ahead and still compilefile()'ng them.

Changing it to below (the double loop because this 
function gets called recursively within the second loop):

    ...
        if self.deep:
            for filename, name in self.depends.items():
                if name in self.skip:
                    del self.depends[filename]
                    self.write('  %s skipping %s' % (mod.name, 
name))

            for filename, name in self.depends.items():
                # self.write('%s requires %s' % (mod.name, 
name))
                self.compilefile(filename, name)

seems to work, but I don't really understand the code 
base well enough to know if this is the 'right' fix.
History
Date User Action Args
2008-02-20 17:17:17adminlinkissue876840 messages
2008-02-20 17:17:17admincreate