Message4124

Author billiejoex
Recipients billiejoex
Date 2009-02-04.03:54:56
SpamBayes Score 4.3951665e-09
Marked as misclassified No
Message-id <1233719698.41.0.513607416078.issue1260@psf.upfronthosting.co.za>
In-reply-to
Content
Hi,
I took a quick look at how asyncore.py has been modified in respect to
the cPython 2.5 version and, if I'm reading the diff correctly, it seems
that:

- OOB data support has been removed
- loop()'s count parameter is gone
- dispatcher's _map attribute seems to get removed in add_channel()
method for no reason (see also issue 12265)
- when calling dispatcher.listen() the add_channel() method gets called
and this is wrong since it results in having a duplicated fd in the
socket map
- dispatcher_with_send class constructor have lost the "map" parameter

Why all these changes? Most of them seem unnecessary to me, if not wrong
at all.
Out of curiosity I've tried to use cPython2.5's asyncore.py with Jython
by running pyftpdlib test suite and it seems it works almost the same so
I don't get most of the decisions that have been taken.
History
Date User Action Args
2009-02-04 03:54:58billiejoexsetrecipients: + billiejoex
2009-02-04 03:54:58billiejoexsetmessageid: <1233719698.41.0.513607416078.issue1260@psf.upfronthosting.co.za>
2009-02-04 03:54:58billiejoexlinkissue1260 messages
2009-02-04 03:54:57billiejoexcreate