Issue1744775

classification
Title: umlauts displayed incorrectly in installer
Type: Severity: normal
Components: Installer Versions:
Milestone:
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: otmarhumbel Nosy List: a_o_m, cgroves, otmarhumbel
Priority: normal Keywords:

Created on 2007-06-28.12:42:39 by a_o_m, last changed 2007-07-01.20:33:52 by otmarhumbel.

Files
File name Uploaded Description Edit Remove
jython installer umlaute.png a_o_m, 2007-06-28.12:42:39
Messages
msg1678 (view) Author: Alexander (a_o_m) Date: 2007-06-28.12:42:39
German umlaut not displayed correctly.

MacOS 10.4.10, Java 1.5.0_07
msg1679 (view) Author: Oti Humbel (otmarhumbel) Date: 2007-06-28.20:42:41
Strange.
Also on Windows XP the 'Umlaute' are not correctly displayed (using the 2.2rc1 build).
But, if I build it on my Windows system, they are displayed correctly.

The installer is relying on resource bundles:
  package org.python.util.install;
  import java.util.ListResourceBundle;
  public class TextConstants_de extends ListResourceBundle implements TextKeys {
      static final Object[][] contents = {
          { ACCEPT, "Ja, ich akzeptiere" }, // license
          { ADVANCED, "Für Fortgeschrittene" }, // global type, and so on ...

Charlie, could you please check if the file installer/src/java/org/python/util/install/TextConstants_de.java in your local repository differs from the one in the full_build_*/checkout directory? If yes, please send me both, if no, please send me one of them. I suspect that the 'Umlaute' were converted somewhere on the way between my checkin and your checkout. 

Thinking of a solution: would it be better to use unicode escapes instead of umlaute in the resource bundle ?
Thanks
msg1680 (view) Author: Oti Humbel (otmarhumbel) Date: 2007-06-28.22:04:42
http://jython.svn.sourceforge.net/viewvc/jython?view=rev&revision=3275
uses unicode escape sequences instead of hard-coded special characters.
The risk for the latter to be converted either in SVN or on a build machine is way too high.

Waiting for verification (need a build on a machine which has a different encoding than mine).
msg1681 (view) Author: Charlie Groves (cgroves) Date: 2007-07-01.19:48:56
http://jython.org/jython_installer-r3276.jar is a build with the hard-coded special characters from my machine.  The old installer had the broken characters in it for me, but this one looks fine.
msg1682 (view) Author: Oti Humbel (otmarhumbel) Date: 2007-07-01.20:33:52
It also looks fine on my machine.
Thanks very much for doing the build !
History
Date User Action Args
2007-06-28 12:42:39a_o_mcreate