Issue2840

I tried to send an email with jython 2.7.1 and jython 2.7.2b2 with the attached mytest_smtplib.py. The attached image is 85 KiB in size.
The OS is openSUSE Leap 15.1. The java version is 1.8.0_222.

The program fails with:

Traceback (most recent call last):
  File "mytest_smtplib.py", line 40, in <module>
    s.sendmail(sender, receiver, msg.as_string())
  File "/usr/local/jython2.7.1/Lib/smtplib.py", line 745, in sendmail
    self.rset()
  File "/usr/local/jython2.7.1/Lib/smtplib.py", line 469, in rset
    return self.docmd("rset")
  File "/usr/local/jython2.7.1/Lib/smtplib.py", line 393, in docmd
    self.putcmd(cmd, args)
  File "/usr/local/jython2.7.1/Lib/smtplib.py", line 341, in putcmd
    self.send(str)
  File "/usr/local/jython2.7.1/Lib/smtplib.py", line 331, in send
    raise SMTPServerDisconnected('Server not connected')
smtplib.SMTPServerDisconnected: Server not connected

The log of the postfix mailserver shows:

2019-11-25T15:15:58.762073+01:00 dios postfix/smtpd[14421]: connect from localhost[127.0.0.1]
2019-11-25T15:15:59.066917+01:00 dios postfix/smtpd[14421]: 104A2A08C1: client=localhost[127.0.0.1]
2019-11-25T15:15:59.126283+01:00 dios postfix/cleanup[14434]: 104A2A08C1: message-id=<20191125141559.104A2A08C1@dios.nixdos.de>
2019-11-25T15:20:59.227259+01:00 dios postfix/smtpd[14421]: timeout after DATA (65507 bytes) from localhost[127.0.0.1]
2019-11-25T15:20:59.227865+01:00 dios postfix/smtpd[14421]: disconnect from localhost[127.0.0.1] ehlo=1 mail=1 rcpt=1 data=0/1 commands=3/4


But the same program works with python.

I added the picture used as an attachment.

We should be able to do better than that. Aiming for 2.7.2

This is quite likely connected with the incomplete nature of our socket implementation, see for example https://github.com/jythontools/jython/issues/104, and I do not think a fix is feasible in the timescale of the 2.7.2 release.

https://bugs.jython.org/issue2894 has the solution for this.

Replace sendall in _socket.py with the version given in  https://github.com/gbach/jython/commit/759c042bbf3d38a761430d3a671e2cdf4a1bf61f

    def sendall(self, data, flags=0):
        chunk_size = 8192
        length = len(data)
        data_view = memoryview(data)
        idx = 0
        while idx < length:
            bytes_sent = self.send(data_view[idx:idx + chunk_size], flags=flags)
            idx += bytes_sent

Hi,

I have been following this bug and I have tried the solution provided.

Now a simple email without the attachments is failing with below error after updating the _socket.py 

 File "E:\lib\Lib\urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "E:\lib\Lib\urllib2.py", line 429, in open
    response = self._open(req, data)
  File "E:\lib\Lib\urllib2.py", line 446, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
  File "E:\lib\Lib\urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "E:\lib\Lib\urllib2.py", line 1228, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "E:\lib\Lib\urllib2.py", line 1195, in do_open
    h.request(req.get_method(), req.get_selector(), req.data, headers)
  File "E:\lib\Lib\urllib2.py", line 1195, in do_open
    h.request(req.get_method(), req.get_selector(), req.data, headers)
  File "E:\lib\Lib\httplib.py", line 1042, in request
    self._send_request(method, url, body, headers)
  File "E:\lib\Lib\httplib.py", line 1082, in _send_request
    self.endheaders(body)
  File "E:\lib\Lib\httplib.py", line 1038, in endheaders
    self._send_output(message_body)
  File "E:\lib\Lib\httplib.py", line 882, in _send_output
    self.send(msg)
  File "E:\lib\Lib\httplib.py", line 858, in send
    self.sock.sendall(data)
  File "E:\lib\Lib\_socket.py", line 1464, in meth
    return getattr(self._sock,name)(*args)
  File "E:\lib\Lib\_socket.py", line 1224, in sendall
    data_view = memoryview(data)
TypeError: cannot make memory view because object does not have the buffer interface

I could successfully execute mytest_smtplib.py with jython 2.7.2 on Windows 10 with Java openjdk 8u302.

Which jython version did you use? Your path of the library, is not the standard. Are you sure that is the one matching jython 2.7.2?

I attached my _socket.py.

jython version is 2.7.2. 

I think the issue is from my custom email py script.

The script is working without socket.py changes and sends out the email with attachment less than 56 KB.

If i update the socket.py script and run my custom script, it fails with the error provided  before even reaching to the email part.

I will work my script and let you know

Handle as https://github.com/jython/jython/issues/60 and PR https://github.com/jython/jython/pull/185 believed to fix.