Issue1718

Attached is a somewhat complete implementation of PEP 3101 (string.format) for Jython 2.6 which passes a certain number of the tests in the standard library testsuite. :)

Stuff that's still missing:
 - implement __format__ for floats
 - implement 'n' formatting type for integers
 - implement __format__ for datetime
 - limit recursion level for recursive format specs
 - implement remaining checks for error conditions
 - check str/unicode difference
 - handle classes inherited from int/long/string/float overriding __format__
 - anything else I haven't figured out yet :)

I'll also note that we're not quite sure how to handle 'n' yet as its locale dependent

I've applied this in r7257, thanks again!

FYI I'll probably be applying just a few small coding standard changes to it over the next few days. I'll keep this open for the ongoing missing features

I applied some minor changes, mostly coding standards in r7261

The only other suggestion I might make is to maybe have the internal stringlib classes throw Py.ValueErrors instead of InvalidArgumentExceptions which propagate up as ValueErrors anyway

To limit recursion you probably just need to surround those potential recursive calls in:

threadState.enterRecursiveCall(" in foo");
try {
    recursiveCall.__call__()
} finally {
    threadState.leaveRecursiveCall();
}

To handle subclasses overriding __format__ we probably just need an entry for __format__ added to src/templates/object.derived and to regenerate our derived subclasses with gderved.py in the same directory

Since the patch has already been committed, does this issue need to be kept open? Or can it be closed?

Might as well leave it open to track the missing features of the PEP

oops I didn't want to close it..

I updated some fields in hopes that this one will stop showing up in the "waiting for review" section of the tracker email.

I've implemented a few more of the items, as well as some 2.6 -> 2.7 changes (bug fixes, thousands separators and {}).

 - implement 'n' formatting type for integers
 - implement remaining checks for error conditions
 - limit recursion level for recursive format specs

Nearly all of the tests from 2.7 pass.  Notably still remaining from the original list:

 - implement __format__ for floats
 - implement __format__ for datetime

I think this one can be closed now, thanks Dmitry!